Hi,
Am getting the following error, anything to do with recent modifications ? I
belive we have to bind the GadgetAdminStore to BasicGadgetAdminStore at
DefaultGuiceModule ?
Regards,
/Nuwan
1) No implementation for org.apache.shindig.gadgets.admin.GadgetAdminStore
was bound.
while locating org.apache.shindig.gadgets.admin.GadgetAdminStore
for parameter 1 at
org.apache.shindig.gadgets.config.CoreUtilConfigContributor.<init>(CoreUtilConfigContributor.java:48)
at
org.apache.shindig.gadgets.config.DefaultConfigContributorModule.registerConfigContributors(DefaultConfigContributorModule.java:37)
2) No implementation for org.apache.shindig.gadgets.admin.GadgetAdminStore
was bound.
while locating org.apache.shindig.gadgets.admin.GadgetAdminStore
for parameter 3 at
org.apache.shindig.gadgets.process.Processor.<init>(Processor.java:61)
while locating org.apache.shindig.gadgets.process.Processor
for parameter 1 at
org.apache.shindig.gadgets.servlet.GadgetsHandlerService.<init>(GadgetsHandlerService.java:163)
while locating org.apache.shindig.gadgets.servlet.GadgetsHandlerService
for parameter 1 at
org.apache.shindig.gadgets.servlet.GadgetsHandler.<init>(GadgetsHandler.java:133)
at
org.apache.shindig.gadgets.DefaultGuiceModule.registerGadgetHandlers(DefaultGuiceModule.java:106)
On Mon, Oct 3, 2011 at 1:16 AM, Ryan Baxter <rbaxte...@gmail.com> wrote:
>
>
> > On 2011-10-02 01:59:29, Henry Saputra wrote:
> > >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.java,
> line 54
> > > <https://reviews.apache.org/r/1666/diff/7/?file=47001#file47001line54>
> > >
> > > Hey Ryan, sorry about the confusion, yeah I was suggesting about
> moving the GadgetAdminModule to web.xml instead of DefaultGuiceModule.
> > >
> > > As for injecting the BasicGadgetAdminStore, I didnt realize that it
> was add it to the GadgetAdminStoreProvider instead of the GadgetAdminModule.
> > >
> > > Getting old =P
>
> Thanks Henry! Committed revision 1178236.
>
>
> - Ryan
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1666/#review2247
> -----------------------------------------------------------
>
>
> On 2011-10-02 19:38:29, Ryan Baxter wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/1666/
> > -----------------------------------------------------------
> >
> > (Updated 2011-10-02 19:38:29)
> >
> >
> > Review request for shindig, Paul Lindner, Henry Saputra, johnfargo, Dan
> Dumont, and Stanton Sievers.
> >
> >
> > Summary
> > -------
> >
> > We want to add some administration features to Shindig. This patch
> adds/changes 3 things in Shindig.
> >
> > 1. Remove the existing blacklist functionality in Shindig which
> currently is enabled by pointing Shindig to a text file with a list of
> gadgets to blacklist. The new functionality uses a whitelist instead of a
> blacklist and is indexed on a per container basis. Meaning an admin could
> whitelist some gadgets in one container but not another. This functionality
> is enabled through a Guice module allowing implementors to use something
> else besides a text file.
> >
> > 2. Add the ability for administrators to specify which features are
> allowed and denied for a specific gadget in a specific container. This
> information is checked in two places, when the metadata request is made and
> when the gadget is rendered.
> >
> > 3. Add the ability for containers to secure RPC requests made by
> gadgets. The RPC code now has the ability to arbitrate all RPC calls made.
> Containers can specify their own arbitrator. The common container has its
> own default arbitrator available.
> >
> >
> > This addresses bug SHINDIG-1601.
> > https://issues.apache.org/jira/browse/SHINDIG-1601
> >
> >
> > Diffs
> > -----
> >
> > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js1177430
> >
> > http://svn.apache.org/repos/asf/shindig/trunk/config/gadget-admin.jsonPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/logging/i18n/MessageKeys.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties1177430
> > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/pom.xml1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/BasicGadgetBlacklist.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetBlacklist.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/RenderingContext.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStore.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/FeatureAdminData.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminData.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminModule.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/GadgetAdminStore.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ServerAdminData.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/config/CoreUtilConfigContributor.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureRegistry.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/BasicGadgetBlacklistTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/FeatureAdminDataTest.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/GadgetAdminDataTest.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ServerAdminDataTest.javaPRE-CREATION
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/process/ProcessorTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/RewriteModuleTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/StyleTagProxyEmbeddedUrlsVisitorTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeProcessor.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/TemplateBasedTagHandlerTest.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/integration/JpaTestGuiceModule.java1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/webapp/WEB-INF/web.xml1177430
> >
> http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java1177430
> >
> > Diff: https://reviews.apache.org/r/1666/diff
> >
> >
> > Testing
> > -------
> >
> > Created/updated unit tests.
> >
> >
> > Thanks,
> >
> > Ryan
> >
> >
>
>
