----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2345/#review2513 -----------------------------------------------------------
Ship it! +1 - Henry On 2011-10-11 18:40:09, Michael Beaver wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2345/ > ----------------------------------------------------------- > > (Updated 2011-10-11 18:40:09) > > > Review request for shindig. > > > Summary > ------- > > As part of the release cycle in our development group, we asked IBM > Information Development to review and edit the log messages in use by > shindig. They fixed some grammatical mistakes, typos in field names, and > provided improved wording in messages based on their guidelines for word > usage and clarity of message content. The attached patch file contains these > updates that we would like to have committed into the shindig base. > Additionally, we are pushing the messages through our various translation > centers and will soon be providing a follow-on patch that contains the NLS > versions of the properties files for the base languages we support. > > This impacts the following files: resource.properties, > resource_en_US.properties, MessageKeys.java, XmlUtil.java, > FeatureResourceLoader.java, and ApiServlet.java > > > This addresses bug SHINDIG-1638. > https://issues.apache.org/jira/browse/SHINDIG-1638 > > > Diffs > ----- > > > /trunk/java/common/src/main/java/org/apache/shindig/common/logging/i18n/MessageKeys.java > 1178236 > /trunk/java/common/src/main/java/org/apache/shindig/common/xml/XmlUtil.java > 1159473 > > /trunk/java/common/src/main/java/org/apache/shindig/protocol/ApiServlet.java > 1159473 > > /trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource.properties > 1178236 > > /trunk/java/common/src/main/resources/org/apache/shindig/common/logging/i18n/resource_en_US.properties > 1178236 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/features/FeatureResourceLoader.java > 1178431 > > Diff: https://reviews.apache.org/r/2345/diff > > > Testing > ------- > > > Thanks, > > Michael > >
