> On 2011-10-12 19:10:08, Paul Lindner wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js, > > line 36 > > <https://reviews.apache.org/r/2348/diff/1/?file=49451#file49451line36> > > > > for readability can you assign these to local variables. Also what > > happens if the regex fails to match? > >
These are local variables within the osapi.container.Service closure. They are not added on to this, because they should not be public. The old default host is included if the container is not injected and no host|path was provided. If something is injected or provided and the format is not expected, bad things will happen. (JS error, service init failure) I suspect that it was always the case though that things would not work right if incorrect values were supplied. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2348/#review2537 ----------------------------------------------------------- On 2011-10-11 19:00:14, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2348/ > ----------------------------------------------------------- > > (Updated 2011-10-11 19:00:14) > > > Review request for shindig. > > > Summary > ------- > > Should now be using the defaults as they were injected if not provided > explicitly through the common container config. > > > This addresses bug SHINDIG-1627. > https://issues.apache.org/jira/browse/SHINDIG-1627 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js > 1181802 > > Diff: https://reviews.apache.org/r/2348/diff > > > Testing > ------- > > Doug, Li, or anyone else interested... > > I know it's been a while coming, but I've been really busy. Could you > please test this small patch to see if it fixes the problem you guys were > having? > > > Thanks, > > Dan > >
