----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2424/#review2657 -----------------------------------------------------------
Ship it! lgtm - Dan On 2011-10-18 19:16:00, Matthew Hatem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2424/ > ----------------------------------------------------------- > > (Updated 2011-10-18 19:16:00) > > > Review request for shindig, Ryan Baxter and Jason Chiang. > > > Summary > ------- > > Containers should be able to override a subset of the rpc handlers of the > actions feature. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > 1183019 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1183019 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js > 1183019 > > Diff: https://reviews.apache.org/r/2424/diff > > > Testing > ------- > > All unit tests pass. > > > Thanks, > > Matthew > >