> On 2011-10-21 17:00:43, Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js, > > line 120 > > <https://reviews.apache.org/r/2527/diff/1/?file=52116#file52116line120> > > > > pixel dimensions instead of percentage?
right, set both the width and height to 100 pixel for the thumbnail image. > On 2011-10-21 17:00:43, Dan Dumont wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js, > > line 142 > > <https://reviews.apache.org/r/2527/diff/1/?file=52118#file52118line142> > > > > I would think you still want width:'100%' and height: '100%' here. > > > > That json bag are the attributes you want set on a node... so you'll > > want <img height="100%" width="100%"... > right? > > > > Or did you mean to change this to pixel dimensions instead of > > percentage? see above - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2527/#review2748 ----------------------------------------------------------- On 2011-10-21 16:26:52, Jason Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2527/ > ----------------------------------------------------------- > > (Updated 2011-10-21 16:26:52) > > > Review request for shindig, Ryan Baxter and Dan Dumont. > > > Summary > ------- > > This patch fix the IE8 rendering issue on both Sample media items gadget and > Sample media items with openGadget API gadget. > All changes are on the gadget code. > Link to JIRA, https://issues.apache.org/jira/browse/SHINDIG-1648 > > > This addresses bug SHINDIG-1648. > https://issues.apache.org/jira/browse/SHINDIG-1648 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js > 1187403 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/Social.js > 1187403 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media/MediaUI.js > 1187403 > > Diff: https://reviews.apache.org/r/2527/diff > > > Testing > ------- > > Test done on the sample container testing with both Firefox and IE8 > > > Thanks, > > Jason > >
