----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2576/ -----------------------------------------------------------
(Updated 2011-10-27 15:45:02.188499) Review request for shindig, Ryan Baxter and Dan Dumont. Changes ------- no problem, I thought that one will have less computation and maybe slightly better performance. Here is the new patch, which Dan will like it.:) Jason Summary ------- IE8 doesn't support both "forEach" and "indexOf" Javascript methods, replace these methods with for loop. This addresses bug SHINDIG-1652. https://issues.apache.org/jira/browse/SHINDIG-1652 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1189339 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1189339 Diff: https://reviews.apache.org/r/2576/diff Testing ------- Test it with the sample container in IE8 Thanks, Jason