Thank you for your inquiry. DVSR_Sarma Krovi is no longer with the firm. For
immediate assistance, please contact Reception at +1-212-478-0000.
Sincerely,
The D. E. Shaw Group
-- 8< --- CUT HERE -------------------------- CUT HERE --- >8 --
From: "jirapos...@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
To: iss...@shindig.apache.org
cc:
Subject: [jira] [Commented] (SHINDIG-1660) Allow ContainerConfig stack to
load property values from external resources and update
BlobCrypterSecurityTokenCodec to use this new feature.
[
https://issues.apache.org/jira/browse/SHINDIG-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149899#comment-13149899
]
jirapos...@reviews.apache.org commented on SHINDIG-1660:
--------------------------------------------------------
bq. On 2011-11-14 19:26:13, Henry Saputra wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java,
line 230
bq. > <https://reviews.apache.org/r/2824/diff/1/?file=57912#file57912line230>
bq. >
bq. > Can we add fail test for the new methods?
That test was there because the BlobCrypterSecurityTokenCodec used to handle
reading in the security token key from an external resource (file or classpath
resource) but that work is now handled by the ContainerConfig loader -- I'll go
ahead and add a couple failure tests there too though.
- Jesse
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2824/#review3213
-----------------------------------------------------------
On 2011-11-14 20:46:51, Jesse Ciancetta wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2824/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-14 20:46:51)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Update the ContainerConfig stack to allow for res://some-resource.txt
and file:///some-file.txt style values in container.js and automatically
resolve these references during initialization. This allows us to refactor
BlobCrypterSecurityTokenCodec to expect to be given the actual encryption key
rather than a key or resource pointer as it does currently.
bq.
bq. This also opens the door for this functionality to be used for other
configuration which we'd like to load from external files (which should be
useful for third party implementers).
bq.
bq.
bq. This addresses bug shindig-1660.
bq. https://issues.apache.org/jira/browse/shindig-1660
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
1201745
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java
1201745
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenCodec.java
1201745
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/util/ResourceLoader.java
1201745
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/config/JsonContainerConfigLoader.java
1201745
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java
1201745
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/DefaultSecurityTokenCodecTest.java
1201745
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/config/JsonContainerConfigLoaderTest.java
1201745
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/resources/classpath-accessible-test-file.txt
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2824/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated/added tests. Ran build, verified unit tests and tested common
container.
bq.
bq.
bq. Thanks,
bq.
bq. Jesse
bq.
bq.
> Allow ContainerConfig stack to load property values from external resources
and update BlobCrypterSecurityTokenCodec to use this new feature.
>
---------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1660
> URL: https://issues.apache.org/jira/browse/SHINDIG-1660
> Project: Shindig
> Issue Type: Improvement
> Reporter: Jesse Ciancetta
>
> Update the ContainerConfig stack to allow for res://some-resource.txt and
file:///some-file.txt style values in container.js and automatically resolve
these references during initialization. This allows us to refactor
BlobCrypterSecurityTokenCodec to expect to be given the actual encryption key
rather than a key or resource pointer as it does currently.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
