Thank you for your inquiry. DVSR_Sarma Krovi is no longer with the firm. For
immediate assistance, please contact Reception at +1-212-478-0000.
Sincerely,
The D. E. Shaw Group
-- 8< --- CUT HERE -------------------------- CUT HERE --- >8 --
From: "jirapos...@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
To: iss...@shindig.apache.org
cc:
Subject: [jira] [Commented] (SHINDIG-1653) Add callback function to print
timing information for gadget preloading.
[
https://issues.apache.org/jira/browse/SHINDIG-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153160#comment-13153160
]
jirapos...@reviews.apache.org commented on SHINDIG-1653:
--------------------------------------------------------
bq. On 2011-11-18 21:51:25, Stanton Sievers wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js,
line 556
bq. > <https://reviews.apache.org/r/2616/diff/4/?file=59402#file59402line556>
bq. >
bq. > Do actions not care about the ON_CLOSED event anymore?
ON_CLOSED used to get called before the site was actually closed, so I moved
it after we close the site. Now ON_BEFORE_CLOSE gets called before site.close
so in order to not regress anything actions and open search should listen for
on_before_close. I will add Igor and Matt to the review so they are aware.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3363
-----------------------------------------------------------
On 2011-11-18 21:16:31, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2616/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-18 21:16:31)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I have added additional lifecycle handlers. My primary use case here is
to be able to time the different events that take place as a gadget is
rendered, but these additional lifecycle handlers may be used for other things
as well.
bq.
bq.
bq. This addresses bug SHINDIG-1653.
bq. https://issues.apache.org/jira/browse/SHINDIG-1653
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js
1203746
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
1203746
bq.
bq. Diff: https://reviews.apache.org/r/2616/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified sample container to log this information and updated unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Add callback function to print timing information for gadget preloading.
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1653
> URL: https://issues.apache.org/jira/browse/SHINDIG-1653
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> I have added additional lifecycle handlers. My primary use case here is to
be able to time the different events that take place as a gadget is rendered,
but these additional lifecycle handlers may be used for other things as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
