Thank you for your inquiry. DVSR_Sarma Krovi is no longer with the firm. For
immediate assistance, please contact Reception at +91-40-6639-0000.
Sincerely,
The D. E. Shaw Group
-- 8< --- CUT HERE -------------------------- CUT HERE --- >8 --
From: "jirapos...@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
To: iss...@shindig.apache.org
cc:
Subject: [jira] [Commented] (SHINDIG-1664) Actions, selection, and open-views
feature issues in a locked domain environment.
[
https://issues.apache.org/jira/browse/SHINDIG-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161817#comment-13161817
]
jirapos...@reviews.apache.org commented on SHINDIG-1664:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2994/
-----------------------------------------------------------
(Updated 2011-12-02 19:50:07.319085)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, and
Stanton Sievers.
Changes
-------
Originally uploaded an earlier version of my patch. This one should be
current.
Summary
-------
As a general rule, any time anyone is writing a feature using RPC, those
endpoints should never expect to get a function (or something that contains a
function) as an argument.
The serialization that happens when running with locked domains will null the
function argument when (and only when) in locked domains (so jsunit tests will
pass).
The check is a bit to expensive to perform for each rpc call so I think
people are just going to have to stay sharp.
Side note:
The ugly code you'll run into to get the gadget holder from a site is
temporary. I want to go in later and refactor gadget sites, gadget holders,
url sites, and url holders to inherit from a common parent an remove a bunch of
the duplication and make the methods make more sense.
This addresses bug SHINDIG-1664.
https://issues.apache.org/jira/browse/SHINDIG-1664
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.url/url_site.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/feature.xml
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/url_site_test.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js
1209641
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js
1209641
Diff: https://reviews.apache.org/r/2994/diff
Testing
-------
Updated jsunit tests, they all pass.
Tested with some gadgets to exercise the open-views, selection, and actions
api.
Thanks,
Dan
> Actions, selection, and open-views feature issues in a locked domain
environment.
>
---------------------------------------------------------------------------------
>
> Key: SHINDIG-1664
> URL: https://issues.apache.org/jira/browse/SHINDIG-1664
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Environment: Shindig with locked domains enabled.
> Reporter: Dan Dumont
>
> Inspection of the code reveals that functions were being passed as
arguments through rpc.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA
administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
