----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3006/#review3619 -----------------------------------------------------------
Ship it! LGTM - Jesse On 2011-12-04 21:04:16, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3006/ > ----------------------------------------------------------- > > (Updated 2011-12-04 21:04:16) > > > Review request for shindig, Jesse Ciancetta and Brian Lillie. > > > Summary > ------- > > After we return from doFetchConcatResources(..) we set the status in doGet. > So lets say we return false from doFetchConcatResources and the content > written to the response was bigger than the buffer. This means we will flush > the buffer and set the status to the OK status then write the rest of the > content and set the status to bad request, but it will be to late we already > set the status to OK > > > This addresses bug SHINDIG-1667. > https://issues.apache.org/jira/browse/SHINDIG-1667 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java > 1210178 > > Diff: https://reviews.apache.org/r/3006/diff > > > Testing > ------- > > Ran unit tests and rendered gadgets in common container > > > Thanks, > > Ryan > >
