-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3037/
-----------------------------------------------------------
(Updated 2011-12-08 15:07:59.683892)
Review request for shindig, Dan Dumont and Stanton Sievers.
Changes
-------
Think my last patch was not using the latest code so I just wanted to make sure
the patch was correct.
Summary
-------
When you call commoncontainer.navigateUrl if the URL cannot be reached the
caller has no way of knowing if the URL was navigated successfully or not. To
solve this we make a head request to the URL we are navigating to and add a
callback to the API.
It is important to note that we will not be caching the response of the head
request. While this could possibly give us better performance we have no way of
guaranteeing the server will still be up next time and everything may fail.
This is different from the gadget case where we have the gadget XML cached on
the server.
This addresses bug SHINDIG-1669.
https://issues.apache.org/jira/browse/SHINDIG-1669
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container.url/container_url_test.js
1211913
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
1211913
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1211913
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1211913
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js
1211913
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js
1211913
Diff: https://reviews.apache.org/r/3037/diff
Testing
-------
Tested in container as well as updating unit tests.
Thanks,
Ryan
