> On 2011-12-07 23:13:36, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 33 > > <https://reviews.apache.org/r/3053/diff/2/?file=62850#file62850line33> > > > > I thought we were going to allot this for floats and dialogs? > > Dan Dumont wrote: > I figured we could have this discussion here. > > In the spec language, I would prefer to say that containers SHOULD > consider coordinates passed in to this method if the target is FLOAT. And > that if the target is anything else, containers MAY consider the coordinates. > > Dialogs are a bit heavy weight, and most containers will probably want to > control where they pop up and how they look. > Floats seem to be to be lighter weight, probably with little to no gadget > chrome. > > Ryan Baxter wrote: > After taking a second look at this, I realized this code was in the EE > sample container, so really the decision over what view types they honor this > for is up to the container, is that correct?
Yes. Though in the spec we strongly suggest doing it for FLOAT and completely optional for everything else. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3053/#review3718 ----------------------------------------------------------- On 2011-12-07 16:53:27, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3053/ > ----------------------------------------------------------- > > (Updated 2011-12-07 16:53:27) > > > Review request for shindig, Ryan Baxter, Jason Chiang, and Stanton Sievers. > > > Summary > ------- > > Also updated the /samplecontainer/examples/embeddedexperiences/ container and > gadgets to demonstrate how one might support the feature. > > A spec update will be written up to account for these changes. > > > This addresses bug SHINDIG-1671. > https://issues.apache.org/jira/browse/SHINDIG-1671 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js > 1211472 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml > 1211472 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js > 1211478 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/open-views/viewEnhancements-test.js > 1211472 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js > 1211472 > > Diff: https://reviews.apache.org/r/3053/diff > > > Testing > ------- > > all tests pass, added a jsunit test case. > > > Thanks, > > Dan > >
