Thanks Li.  That was my initial implementation (to add something to the
accessor).  However I backed off because I was trying to be the least
intrusive.

Mike and I will go back and see if there is a better way to do this.  Just
not sure how you'd make it generic enough to figure out what request
parameters need to transfer.

What should I do with the code review request in the meantime?  Is there a
way to cancel it, change the code around, and resubmit.  Sorry for my
ignorance.  First time around doing this.

doug


On 12/8/11 2:24 PM, "Li Xu" <leeg...@gmail.com> wrote:

> Hi, Mike
> 
> Thanks for the usecase. It makes sense to me and it could be quite common
> to have vendor specific extension parameters. Just think we may need a
> generic way to support that for both authorization endpoint and token
> endpoint...
> 
> Here's a suggestion...
> Pass in real request parameters from HttpRequest into OAuth2Accessor as a
> Map. This can be set under BasicOAuth2Request.fetch function just before
> attemptFetch.
> Then it will be available for all the endpoint to use for the whole OAuth2
> flow.
> 
> Thanks,
> li


Reply via email to