----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3064/#review3849 -----------------------------------------------------------
Ship it! It looks pretty good to me, thanks for the patch! I can help you commit. Please clean up following minor things. 1. please fill in the test field and indicate what tests you have done. 2. please clean up the use about Maps. please use com.google.common.collect.Maps. 3. please fix up the spacing in java, if you use Eclipse IDE, you can find all the coding style templates under Shindig-project/etc/eclipse thanks! li - li On 2011-12-12 16:48:18, Doug Davies wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3064/ > ----------------------------------------------------------- > > (Updated 2011-12-12 16:48:18) > > > Review request for shindig. > > > Summary > ------- > > It would be nice if the GrantRequestHandler had access to the original > request object so that it could use values like the security token to pass > along additional params to the authorization code request. In our > implementation we set values within the security token's trusted json field > that we'd like to pass along to our GrantRequestHandler implementation. > > > This addresses bug SHINDIG-1672. > https://issues.apache.org/jira/browse/SHINDIG-1672 > > > Diffs > ----- > > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Accessor.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2RequestParameterGenerator.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Accessor.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestParameterGenerator.java > PRE-CREATION > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandler.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandler.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeGrantTypeHandler.java > 1212126 > > /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandler.java > 1212126 > > /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/http/DefaultRequestPipelineTest.java > 1212126 > > Diff: https://reviews.apache.org/r/3064/diff > > > Testing > ------- > > > Thanks, > > Doug > >
