> On 2011-12-20 14:00:30, Ryan Baxter wrote: > > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js, > > line 207 > > <https://reviews.apache.org/r/3165/diff/2/?file=64332#file64332line207> > > > > I believe jQuery provides a function that we can use instead of eval
The jQuery eval function that I found was.. http://api.jquery.com/jQuery.globalEval/ >From the doc.. "This method behaves differently from using a normal JavaScript eval() in that it's executed within the global context (which is important for loading external scripts dynamically)." In this case, I'm not sure if it is necessary or even desirable to allow the user input to run within the global context but I'm still a mostly novice JavaScript programmer so I can be easily convinced otherwise. Unless it does some input sanitizing or something. - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4011 ----------------------------------------------------------- On 2011-12-21 16:05:37, Matt Marum wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3165/ > ----------------------------------------------------------- > > (Updated 2011-12-21 16:05:37) > > > Review request for shindig. > > > Summary > ------- > > As we start to build (and promote the use of) embedded experience gadgets, we > need to provide easier ways for Gadget developers to quickly prototype these > gadgets. I'd like to add an Embedded Experience Gadgets section to the Common > Container test environment > (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can > quickly set a Gadget URL and the context to be passed on render. > > This has makes quickly testing EE gadgets much easier. > > > This addresses bug SHINDIG-1675. > https://issues.apache.org/jira/browse/SHINDIG-1675 > > > Diffs > ----- > > /trunk/content/samplecontainer/examples/commoncontainer/assembler.js > 1220905 > /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js > 1220905 > /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905 > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js > 1220905 > > Diff: https://reviews.apache.org/r/3165/diff > > > Testing > ------- > > Tested locally with some EE gadgets I've been building. Andy Smith has used > it too. There are no automated tests for the sample containers. > > > Thanks, > > Matt > >
