----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3566/#review4535 -----------------------------------------------------------
Ship it! LGTM - Dan On 2012-01-20 16:53:37, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3566/ > ----------------------------------------------------------- > > (Updated 2012-01-20 16:53:37) > > > Review request for shindig and johnfargo. > > > Summary > ------- > > See "SHINDIG-1678 The flash transport to support RPC for IE7 has problem with > multiple gadgets in a single container" > https://issues.apache.org/jira/browse/SHINDIG-1678 for detail description > about the review. > > Proposed fix is to flush the handshakes objects whenever new gadgets call > gadgets.rpc.setupReceiver is called to make sure the container side register > the child iframe info to the flash component. > > > This addresses bug SHINDIG-1678. > https://issues.apache.org/jira/browse/SHINDIG-1678 > > > Diffs > ----- > > trunk/features/src/main/javascript/features/rpc/flash.transport.js 1233272 > > Diff: https://reviews.apache.org/r/3566/diff > > > Testing > ------- > > Running multiple gadgets in common container in IE7 > > > Thanks, > > Henry > >
