----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/ -----------------------------------------------------------
(Updated 2012-02-02 10:53:21.630237) Review request for shindig. Changes ------- New patch is applied. As discussed, by default only the viewer can update his own info. The containers can override this behavior in PersonServiceDb.java For example, String uid = id.getUserId(token); instead of String uid = token.getViewerId(); Test for osapi.people.update is added as well Summary ------- A patch that enables API for updating person data PUT people/12/@self osapi.people.update() for this JIRA reports https://issues.apache.org/jira/browse/SHINDIG-1674 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java 1239531 http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDbTest.java 1239531 http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java 1239531 http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/resources/endtoend/osapi/personTest.xml 1239531 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java 1239531 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/PersonService.java 1239531 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1239531 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1239531 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1239531 Diff: https://reviews.apache.org/r/3544/diff Testing ------- tests are in the patch Thanks, Evgeny
