----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3695/#review4830 -----------------------------------------------------------
Ship it! LGTM I applied the patch, ran the SVN move commands and was then able to "mvn clean install" without any issues and successfully deployed/tested the resulting war file as well. It would be nice if someone else could do the same though (preferably someone who understands maven well) just to validate before I commit the changes to trunk. I'd like to commit by this Wednesday afternoon (2/8/2012) -- maybe by 2PM eastern time? Does that give anyone interested enough time to review as well? If anyone would like more time to review please let me know. - Jesse On 2012-02-03 21:03:25, Ate Douma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3695/ > ----------------------------------------------------------- > > (Updated 2012-02-03 21:03:25) > > > Review request for shindig. > > > Summary > ------- > > This is an *artificial* patch showing the *end* result of the proposed > changes. > These changes assume several source *moves*, which cannot be reliably > captured as an svn diff. > If this patch is accepted, it probably is best to do (part of) the proposed > steps as described in https://issues.apache.org/jira/browse/SHINDIG-1691 > manually. > > Note: I've created this patch using svn 1.7.2 with (1.7+ only) command > parameters: svn diff --show-copies-as-adds --no-diff-deleted > > > This addresses bug SHINDIG-1691. > https://issues.apache.org/jira/browse/SHINDIG-1691 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/java/sample-container/pom.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/server-dependencies/pom.xml > PRE-CREATION > http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/pom.xml > PRE-CREATION > http://svn.apache.org/repos/asf/shindig/trunk/java/server/pom.xml 1235579 > http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1235579 > > Diff: https://reviews.apache.org/r/3695/diff > > > Testing > ------- > > > Thanks, > > Ate > >
