----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3764/#review4831 -----------------------------------------------------------
There seems to be trailing whitespace and some tabs in this patch. Can you clean those up please? /trunk/java/common/src/main/java/org/apache/shindig/protocol/RequestItem.java <https://reviews.apache.org/r/3764/#comment10615> In BaseRequestItem there is already a "public Map<String, Object> getParameters()". Can that API simply be added to the RequestItem interface instead of introducing a new method altogether? You'd then just get the keySet from that instead of using getParameterNames(). - Stanton On 2012-02-06 13:25:25, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3764/ > ----------------------------------------------------------- > > (Updated 2012-02-06 13:25:25) > > > Review request for shindig and Eric Woods. > > > Summary > ------- > > > We have a use case that need to support optional parameters on Social REST > API. > > Per open social spec discussion, provider specific parameter can be > supported. Please see the link below for details. > https://groups.google.com/forum/#!topic/opensocial-and-gadgets-spec/rOBmu4QGtwg > > This patch implemented optional parameter as a field in CollectionOptions. > > > This addresses bug SHINDIG-1698. > https://issues.apache.org/jira/browse/SHINDIG-1698 > > > Diffs > ----- > > > /trunk/java/common/src/main/java/org/apache/shindig/protocol/RequestItem.java > 1238916 > > /trunk/java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java > 1238916 > > /trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/CollectionOptions.java > 1238916 > > Diff: https://reviews.apache.org/r/3764/diff > > > Testing > ------- > > Passed junit tests. tested with a backend that supports optional parameters. > > > Thanks, > > li > >
