Re: Review Request: SHINDIG-1701 Change the action_container.js rpc registration to call the Container.rpcRegister instead directly call gadgets.rpc.register

[Ryan Baxter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3777/#review4892
-----------------------------------------------------------

Ship it!


LGTM

- Ryan


On 2012-02-07 22:41:01, Henry Saputra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3777/
> -----------------------------------------------------------
> 
> (Updated 2012-02-07 22:41:01)
> 
> 
> Review request for shindig, Ryan Baxter and Dan Dumont.
> 
> 
> Summary
> -------
> 
> See jira https://issues.apache.org/jira/browse/SHINDIG-1701
> 
> 
> This addresses bug SHINDIG-1701.
>     https://issues.apache.org/jira/browse/SHINDIG-1701
> 
> 
> Diffs
> -----
> 
>   trunk/features/src/main/javascript/features/actions/actions_container.js 
> 1241570 
> 
> Diff: https://reviews.apache.org/r/3777/diff
> 
> 
> Testing
> -------
> 
> Run mvn clean install and sanity test with conservcontainer
> 
> 
> Thanks,
> 
> Henry
> 
>