----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review5013 -----------------------------------------------------------
Ship it! Committed r1242959 - Dan On 2012-02-08 20:29:31, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3768/ > ----------------------------------------------------------- > > (Updated 2012-02-08 20:29:31) > > > Review request for shindig, Ryan Baxter and Stanton Sievers. > > > Summary > ------- > > With the desire to deprecate the makeRequest API, we still need a method to > post files through the proxy. This new feature should not be bundled in with > core, it should need to be explicitly requested. > > It should allow modern browsers such as FF and Chrome to monitor form post > progress. It should still be functional (do the post) for less capable > browsers like IE, even though post progress may not be available. > > > This addresses bug SHINDIG-1695. > https://issues.apache.org/jira/browse/SHINDIG-1695 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js > 1241308 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt > 1241308 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml > PRE-CREATION > http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js > 1241308 > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java > 1241308 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java > 1241308 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java > 1241308 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java > 1241308 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java > 1241308 > > Diff: https://reviews.apache.org/r/3768/diff > > > Testing > ------- > > > Thanks, > > Dan > >
