----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3936/#review5224 -----------------------------------------------------------
Committed revision 1291469. - Ryan On 2012-02-16 21:42:09, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3936/ > ----------------------------------------------------------- > > (Updated 2012-02-16 21:42:09) > > > Review request for shindig. > > > Summary > ------- > > In core.log the private _console var is set when the javascript is evaluated > in the page. If you are providing your own instance of the console object > than the object might not be created when this javascript is evaluated. A > better approach is to set the private _console var the first time anything is > logged. This gives other javascript a chance to load into the page before we > set this variable. > > > This addresses bug SHINDIG-1708. > https://issues.apache.org/jira/browse/SHINDIG-1708 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.log/log.js > 1245178 > > Diff: https://reviews.apache.org/r/3936/diff > > > Testing > ------- > > All unit tests pass and tested in containers > > > Thanks, > > Ryan > >
