----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4135/#review5615 -----------------------------------------------------------
Committed as 1297157 - Henry On 2012-03-02 19:56:52, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4135/ > ----------------------------------------------------------- > > (Updated 2012-03-02 19:56:52) > > > Review request for shindig. > > > Summary > ------- > > Simplify the SecurityToken.getActiveUrl implementation and definition. > > If not set simply return null should be suffice. > > > This addresses bug SHINDIG-1719. > https://issues.apache.org/jira/browse/SHINDIG-1719 > > > Diffs > ----- > > > trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenTest.java > 1295758 > trunk/java/common/src/main/java/org/apache/shindig/auth/SecurityToken.java > 1295758 > > trunk/java/common/src/main/java/org/apache/shindig/auth/BasicSecurityToken.java > 1295758 > > trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityToken.java > 1295758 > > Diff: https://reviews.apache.org/r/4135/diff > > > Testing > ------- > > Updated unit test and run apps in common container > > > Thanks, > > Henry > >