----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4202/#review5653 -----------------------------------------------------------
Ship it! LGTM - Adam On 2012-03-06 19:29:51, li xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4202/ > ----------------------------------------------------------- > > (Updated 2012-03-06 19:29:51) > > > Review request for shindig. > > > Summary > ------- > > As part of the release cycle in our development group, we asked IBM > Information Development to review and edit the log messages in use by > shindig. They fixed some grammatical mistakes, typos in field names, and > provided improved wording in messages based on their guidelines for word > usage and clarity of message content. The attached patch file contains these > updates that we would like to have committed into the shindig base. > Additionally, we are pushing the messages through our various translation > centers and will soon be providing a follow-on patch that contains the NLS > versions of the properties files for the base languages we support. > > We also cleaned up the testcases to remove checks on message texts. > > > This addresses bug SHINDIG-1722. > https://issues.apache.org/jira/browse/SHINDIG-1722 > > > Diffs > ----- > > > trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties > 1244227 > > trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties > 1244227 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ErrorTest.java > 1244227 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestExceptionTest.java > 1244227 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java > 1244227 > > trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLoggerTest.java > 1244227 > > Diff: https://reviews.apache.org/r/4202/diff > > > Testing > ------- > > passed junit tests. > > > Thanks, > > li > >
