-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4216/
-----------------------------------------------------------
Review request for shindig and Henry Saputra.
Summary
-------
runAction function receives an empty array when it calls the
registry.getGadgetSites instead of "undefined", which is what it receives when
gadget loading works in earlier builds. Therefore, the first section in "if
(!gadgetSites)" below doesn't get run and instead it incorrectly goes to the
"else". .getGadgetSites appears to now always return an array and it will be
empty if there aren't any sites instead of "undefined" like in the past.
runAction: function(actionId, opt_selection) {
var action = registry.getItemById(actionId);
if (action) {
// if gadget site has not been registered yet
// the gadget needs to be rendered
var gadgetSites = registry.getGadgetSites(actionId);
if (!gadgetSites) {
var gadgetUrl = registry.getUrl(actionId);
pendingActions[actionId] = {
selection: opt_selection || container_.selection.getSelection()
};
// set optional params
......
},
This addresses bug SHINDIG-1723.
https://issues.apache.org/jira/browse/SHINDIG-1723
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js
1297846
Diff: https://reviews.apache.org/r/4216/diff
Testing
-------
Done.
Thanks,
Yao
