> On 2012-03-13 20:44:46, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js, > > line 312 > > <https://reviews.apache.org/r/4321/diff/2/?file=91789#file91789line312> > > > > Is the name of this method just midleading, would it also return URL > > sites?
Yes. All sites. I think i put a todo in there where it's defined. The container will keep track of all sites. - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4321/#review5893 ----------------------------------------------------------- On 2012-03-13 20:12:36, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4321/ > ----------------------------------------------------------- > > (Updated 2012-03-13 20:12:36) > > > Review request for shindig. > > > Summary > ------- > > Now passing along the calling site into the createElementFor* methods so that > containers can use that info when making new elements. > > > This addresses bug SHINDIG-1735. > https://issues.apache.org/jira/browse/SHINDIG-1735 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js > 1300267 > > Diff: https://reviews.apache.org/r/4321/diff > > > Testing > ------- > > Build passed. > > > Thanks, > > Dan > >
