----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5936 -----------------------------------------------------------
Ship it! Committed r1300552 - Dan On 2012-03-13 18:36:35, Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4310/ > ----------------------------------------------------------- > > (Updated 2012-03-13 18:36:35) > > > Review request for shindig. > > > Summary > ------- > > Updated sample gadgets. > Added a dummy listener to the selection queue so that a gadget will always > watch selection. > Selection registration now returns the current selection so that gadgets can > prime their selection cache. > > > This addresses bug SHINDIG-1727. > https://issues.apache.org/jira/browse/SHINDIG-1727 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml > 1300267 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js > 1300267 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js > 1300267 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js > 1300267 > > Diff: https://reviews.apache.org/r/4310/diff > > > Testing > ------- > > Updated and ran unit tests. > Updated sample gadgets, ran sample gadgets in the sample container. > > > Thanks, > > Dan > >
