----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4366/#review6070 -----------------------------------------------------------
Ship it! LGTM - Ryan On 2012-03-15 17:47:31, Doug Davies wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4366/ > ----------------------------------------------------------- > > (Updated 2012-03-15 17:47:31) > > > Review request for shindig and Paul Lindner. > > > Summary > ------- > > This is a fix for SHINDIG-1736. Currently the recently updated JsonUtil > blows up if the class it is trying to parse has synthetic methods generated > by the compiler for handling runtime generics substitution. It now checks to > make sure the method is not synthetic. I've included a unit test that tests > this scenario. > > > This addresses bug SHINDIG-1736. > https://issues.apache.org/jira/browse/SHINDIG-1736 > > > Diffs > ----- > > /trunk/java/common/src/main/java/org/apache/shindig/common/JsonUtil.java > 1299867 > > /trunk/java/common/src/test/java/org/apache/shindig/common/JsonUtilTest.java > 1299867 > > Diff: https://reviews.apache.org/r/4366/diff > > > Testing > ------- > > unit test provided > > > Thanks, > > Doug > >
