----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4273/ -----------------------------------------------------------
(Updated 2012-03-19 17:43:45.731644) Review request for shindig, Dan Dumont and Adam Clarke. Changes ------- Update JUnits (that would have caught this regression had they been in place) and added some simple JUnits for the other support methods through makeRequest. The tests for HEAD, DELETE, and PATCH can probably be improved and I'm open to suggestions. I also fixed a couple of checkstyle warnings regarding line length. Summary ------- Currently I can use gadgets.io.makeRequest to do a PUT but the PUT body does not reach the destination. This works today for POST, it simply seems that PUT was left out of that implementation. This addresses bug SHINDIG-1728. https://issues.apache.org/jira/browse/SHINDIG-1728 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1302537 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1302537 Diff: https://reviews.apache.org/r/4273/diff Testing ------- Thanks, Stanton