----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4291/#review6803 -----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java <https://reviews.apache.org/r/4291/#comment15177> Just a suggestion but you might want to create a common function to create the gadgetUri as you repeat this code several times. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java <https://reviews.apache.org/r/4291/#comment15172> Small nit, space before equals http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java <https://reviews.apache.org/r/4291/#comment15173> white space http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java <https://reviews.apache.org/r/4291/#comment15176> Makes the code easier to read if you do && here http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java <https://reviews.apache.org/r/4291/#comment15174> white space - Ryan On 2012-04-09 20:02:38, Adam Clarke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4291/ > ----------------------------------------------------------- > > (Updated 2012-04-09 20:02:38) > > > Review request for shindig, Ryan Baxter and li xu. > > > Summary > ------- > > Allows multiple gadgets to share a token by binding to an OAuth2Client with > sharedToken=true > > > This addresses bug SHINDIG-1731. > https://issues.apache.org/jira/browse/SHINDIG-1731 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java > 1311391 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Message.java > 1311391 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Client.java > 1311391 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/sample/JSONOAuth2Persister.java > 1311391 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2ClientTest.java > 1311391 > > Diff: https://reviews.apache.org/r/4291/diff > > > Testing > ------- > > All test cases pass. > > > Thanks, > > Adam > >
