----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4710/ -----------------------------------------------------------
Review request for shindig. Summary ------- Fix shindig to implement the stated spec, that the libs param should be a url to download feature impl, not just a list of features. Additional conversation on the spec list here: https://groups.google.com/d/topic/opensocial-and-gadgets-spec/7lGzhk67nY8/discussion This addresses bug SHINDIG-1707. https://issues.apache.org/jira/browse/SHINDIG-1707 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/url-gadget-with-features/url.html PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/url-gadget-with-features/url.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1311965 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1311965 Diff: https://reviews.apache.org/r/4710/diff Testing ------- Updated unit tests to expect the new url. All tests pass. Added a sample url gadget and html page to show the feature working. Thanks, Dan
