----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/#review7699 -----------------------------------------------------------
Ship it! +1 Looks good to me - Henry On 2012-05-08 20:47:26, Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5055/ > ----------------------------------------------------------- > > (Updated 2012-05-08 20:47:26) > > > Review request for shindig and Henry Saputra. > > > Summary > ------- > > Section 2.1.1.1 of the Social Server API spec indicates that when a GET > request is made to the person API with a user id of -1 we should return the > anonymous user. Today we are throwing an exception because we look for a > person with -1 as their id in the canonicaldb and we can't find it. > > http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 > > > This addresses bug SHINDIG-1769. > https://issues.apache.org/jira/browse/SHINDIG-1769 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java > 1335204 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java > 1335204 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties > 1335204 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java > 1335204 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java > 1335204 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java > 1335204 > > Diff: https://reviews.apache.org/r/5055/diff > > > Testing > ------- > > Updated unit tests > > > Thanks, > > Ryan > >
