-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5085/
-----------------------------------------------------------
(Updated 2012-05-14 12:39:40.305248)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Summary
-------
The OpenSocial spec says that you should be able to pass 'SIGN_OWNER' and
'SIGN_VIEWER' as parameters to makeRequest. Shindig does not define these and
in fact looks for the wrong parameters. In io.js Shindig looks for
'OWNER_SIGNED' and 'VIEWER_SIGNED'. In addition 'SIGN_OWNER' and 'SIGN_VIEWER'
should be made constants.
This addresses bug shindig-1772.
https://issues.apache.org/jira/browse/shindig-1772
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
1327432
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
1327432
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
1327432
Diff: https://reviews.apache.org/r/5085/diff
Testing
-------
Update iotest.js
Thanks,
Erik
