----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5107/#review7867 -----------------------------------------------------------
Ship it! LGTM http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/AllJsFilter.java <https://reviews.apache.org/r/5107/#comment17198> You might want to consider adding something to the documentation stating that 'all' is a reserved feature name. Not that it is likely, but there could be a collision. - Matt On 2012-05-14 17:00:10, Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5107/ > ----------------------------------------------------------- > > (Updated 2012-05-14 17:00:10) > > > Review request for shindig. > > > Summary > ------- > > See the JIRA for the high-level description. > > My approach to doing this was to introduce a new test case in the end-to-end > tests. This way I can test with a real FeatureRegistry against the real web > app. I make a request to the JsServlet for all of the features, which will > run through the compiler processors. Because of the changes that went in for > https://issues.apache.org/jira/browse/SHINDIG-1770, we will return the > compile error and this will get printed as part of the JUnit assert failure, > pin-pointing the exact compile problem. > > Note that this does increase the time it takes to execute the EndToEndTest on > the scale of tens of seconds. > > > This addresses bug SHINDIG-1771. > https://issues.apache.org/jira/browse/SHINDIG-1771 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/AllJsFilter.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndServer.java > 1337280 > > http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java > 1337280 > > Diff: https://reviews.apache.org/r/5107/diff > > > Testing > ------- > > Introduced some JS errors and verified that the unit test failed. > Additionally verified the reason for the failure was readily available. > > > Thanks, > > Stanton > >
