----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4268/#review8017 -----------------------------------------------------------
LGTM for the most part. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/GroupImpl.java <https://reviews.apache.org/r/4268/#comment17391> I think this should be an IllegalArgumentException and not InvalidParameterException, which resides in java.security. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Group.java <https://reviews.apache.org/r/4268/#comment17392> This is no longer just valid GroupId object. It can be a valid GroupId representation. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/DomainName.java <https://reviews.apache.org/r/4268/#comment17393> This should be throwing IllegalArgumentException and not InvalidParameterException http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/DomainName.java <https://reviews.apache.org/r/4268/#comment17396> Should the "." in this regex be escaped with "\\"? So the regex would be "[a-zA-Z0-9_\\.-]*" You might be able to use \w to represent a word in this case. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/DomainName.java <https://reviews.apache.org/r/4268/#comment17398> IllegalArgumentException, please. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GlobalId.java <https://reviews.apache.org/r/4268/#comment17401> throw IllegalArgumentException, please. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GlobalId.java <https://reviews.apache.org/r/4268/#comment17402> throw IllegalArgumentException, please. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GlobalId.java <https://reviews.apache.org/r/4268/#comment17403> Small nit on style here. You're using the getters on the local object and accessing the fields directly on the other object. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java <https://reviews.apache.org/r/4268/#comment17404> throw IllegalArgumentException, please. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java <https://reviews.apache.org/r/4268/#comment17405> Small nit on style. The else if statements aren't needed because you're returning. These can be consecutive ifs. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java <https://reviews.apache.org/r/4268/#comment17406> Small nit on style. These can be consecutive ifs because of the returns. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java <https://reviews.apache.org/r/4268/#comment17407> Small nit on style. Don't need the else because of the return in the if body. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/LocalId.java <https://reviews.apache.org/r/4268/#comment17409> Use IllegalArgumentException, please. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/LocalId.java <https://reviews.apache.org/r/4268/#comment17408> Same comments as for the domain name regex. http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/ObjectId.java <https://reviews.apache.org/r/4268/#comment17410> Use IllegalArgumentException instead, please. - Stanton On 2012-05-17 14:02:58, Mike May wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4268/ > ----------------------------------------------------------- > > (Updated 2012-05-17 14:02:58) > > > Review request for shindig, Henry Saputra, Ryan Baxter, and Stanton Sievers. > > > Summary > ------- > > A base implementation for OpenSocial Groups. Provides groups to the osapi > javascript namespace with an implementation link for get() in GroupService. > > > This addresses bug SHINDIG-1780. > https://issues.apache.org/jira/browse/SHINDIG-1780 > > > Diffs > ----- > > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/SocialHelloWorld.xml > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/content/sampledata/canonicaldb.json > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/ActivityServiceDb.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/AppDataServiceDb.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/main/java/org/apache/shindig/social/opensocial/jpa/spi/PersonServiceDb.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiDatabaseBootstrap.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/java/org/apache/shindig/social/opensocial/jpa/spi/SpiTestUtil.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/samples/src/test/resources/sampledata/canonicaldb.json > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/GroupImpl.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Group.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/DomainName.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GlobalId.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/GroupId.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/LocalId.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/ObjectId.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/SampleModule.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonPeopleTest.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulXmlPeopleTest.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/DomainNameTest.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GlobalIdTest.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/GroupIdTest.java > 1339181 > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/LocalIdTest.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/spi/ObjectIdTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4268/diff > > > Testing > ------- > > Used the common container with a gadget to call osapi.groups.get() > > -- > > Created and updated unit tests > All tests pass > > > Thanks, > > Mike > >
