----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5390/#review8390 -----------------------------------------------------------
Ship it! Ship It! - Dan Dumont On June 18, 2012, 6:04 p.m., Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5390/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 6:04 p.m.) > > > Review request for shindig and Henry Saputra. > > > Description > ------- > > If an EE data model only has a URL and specifies a target type of gadget in > its preferred experience the EE container code will still try to render a > gadget. According to the spec if a data model specifies a target type that > the data model does not contain than the container should ignore the target > type. > http://opensocial-resources.googlecode.com/svn/spec/trunk/Core-Gadget.xml#rfc.section.C.15.3.2 > > > This addresses bug SHINDIG-1802. > https://issues.apache.org/jira/browse/SHINDIG-1802 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js > 1350227 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js > 1350227 > > Diff: https://reviews.apache.org/r/5390/diff/ > > > Testing > ------- > > Updated unit tests > > > Thanks, > > Ryan Baxter > >
