----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5422/ -----------------------------------------------------------
(Updated June 20, 2012, 12:32 p.m.) Review request for shindig, Ryan Baxter and Doug Davies. Changes ------- Per suggestion, removed the optional injection of the SecurityTokenCodec and the check for no codec. Test updated to comply with this change. Description ------- Continuing review started @ http://codereview.appspot.com/6306074/ Have modified retrieveServices to accept container as parameter, and use to generate security token This addresses bug SHINDIG-1799. https://issues.apache.org/jira/browse/SHINDIG-1799 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java 1350364 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java 1350372 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/DefaultServiceFetcherTest.java 1347033 Diff: https://reviews.apache.org/r/5422/diff/ Testing ------- Tests pass. EndToEndTest passes with allowUnauthenticated=false, and with secure tokens enabled Thanks, Brian Lillie
