----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1960/#review8434 -----------------------------------------------------------
Seems like this is fixed right? The JIRA is closed....could we close this review as well? - Ryan Baxter On June 19, 2012, 2 p.m., Brian Lillie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1960/ > ----------------------------------------------------------- > > (Updated June 19, 2012, 2 p.m.) > > > Review request for shindig. > > > Description > ------- > > If the OAuthResponseParms code calls logDetailedWarning or logDetailedInfo, > it passes a message key expecting the Logging call to translate the msgKey > into a message. However, no resource bundle was associated with the logger so > the translation does not occur. > > > This addresses bug SHINDIG-1625. > https://issues.apache.org/jira/browse/SHINDIG-1625 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java > 1164090 > > Diff: https://reviews.apache.org/r/1960/diff/ > > > Testing > ------- > > > Thanks, > > Brian Lillie > >
