----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5539/#review8542 -----------------------------------------------------------
Ship it! Ship It! - Dan Dumont On June 23, 2012, 8:02 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5539/ > ----------------------------------------------------------- > > (Updated June 23, 2012, 8:02 p.m.) > > > Review request for shindig and Dan Dumont. > > > Description > ------- > > Adding protected onError and onRedirect methods that allow for > post-processing by subclasses in the event that there was an error thrown or > a redirect needed. This allows subclasses to easily change the error > behavior without having to re-invent the functionality in doFilter. > > > This addresses bug SHINDIG-1800. > https://issues.apache.org/jira/browse/SHINDIG-1800 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AuthenticationServletFilter.java > 1352560 > > Diff: https://reviews.apache.org/r/5539/diff/ > > > Testing > ------- > > Existing JUnits pass. Performed functional testing in a private container. > > > Thanks, > > Stanton Sievers > >
