----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5568/#review8572 -----------------------------------------------------------
LGTM - Brian Lillie On June 25, 2012, 10:07 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5568/ > ----------------------------------------------------------- > > (Updated June 25, 2012, 10:07 p.m.) > > > Review request for shindig, Brian Lillie and Doug Davies. > > > Description > ------- > > If we set the X-Shindig-ST header to null in WebKit browsers, it will get > interpreted as the String "null" on the server side and cause > SecurityTokenExceptions. > > > This addresses bug SHINDIG-1812. > https://issues.apache.org/jira/browse/SHINDIG-1812 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js > 1352560 > > Diff: https://reviews.apache.org/r/5568/diff/ > > > Testing > ------- > > Existing JUnits pass. > > > Thanks, > > Stanton Sievers > >
