----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1684/#review8626 -----------------------------------------------------------
Ship it! Patch might need an update. So old :) - superddumont On Aug. 30, 2011, 9:45 p.m., Ryan Baxter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1684/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2011, 9:45 p.m.) > > > Review request for shindig. > > > Description > ------- > > Add the set title handler to the example common container so when gadgets > call the setTitle API it actually reflects in the containers API. > > > This addresses bug SHINDIG-1610. > https://issues.apache.org/jira/browse/SHINDIG-1610 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js > 1163388 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js > 1163388 > > Diff: https://reviews.apache.org/r/1684/diff/ > > > Testing > ------- > > Tested the API in the container. > > > Thanks, > > Ryan Baxter > >
