----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5592/#review8632 -----------------------------------------------------------
We are already converting the message parameters from the original object to a String here .. wondering whether we should be converting from null to an empty string, when ordinarily I believe null would changed to be "null" http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLogger.java <https://reviews.apache.org/r/5592/#comment18267> Seems like this could be removed, and filterSecrets used where filteredMsg is called. filteredParam uses filterSecrets directly, but filteredParams does the extra indirect to filteredMsg - Brian Lillie On June 26, 2012, 6:50 p.m., Adam Clarke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5592/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 6:50 p.m.) > > > Review request for shindig, Stanton Sievers and Brian Lillie. > > > Description > ------- > > Adds additional filters for client_secret and refresh_token, which could be > considered passwords and shouldn't be logged. > > > This addresses bug SHINDIG-1813. > https://issues.apache.org/jira/browse/SHINDIG-1813 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLogger.java > 1354123 > > Diff: https://reviews.apache.org/r/5592/diff/ > > > Testing > ------- > > all units pass > > > Thanks, > > Adam Clarke > >
