----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5497/#review8658 -----------------------------------------------------------
Ship it! Please update the JIRA and I'll get this committed. Thanks. - Stanton Sievers On June 26, 2012, 8:33 p.m., Brian Lillie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5497/ > ----------------------------------------------------------- > > (Updated June 26, 2012, 8:33 p.m.) > > > Review request for shindig. > > > Description > ------- > > Add check for non-null encrypter. There were two test methods > (testSetSecret_1 and testSetSecret_2) that were identical.. so modified > second to not supply encrypter as parameter to constructor. > > > This addresses bug SHINDIG-1810. > https://issues.apache.org/jira/browse/SHINDIG-1810 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistence.java > 1347033 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2TokenPersistenceTest.java > 1348118 > > Diff: https://reviews.apache.org/r/5497/diff/ > > > Testing > ------- > > Tests pass > > > Thanks, > > Brian Lillie > >
