----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5688/#review8810 -----------------------------------------------------------
Ship it! Committed revision 1356385. - Stanton Sievers On July 2, 2012, 6 p.m., Stanton Sievers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5688/ > ----------------------------------------------------------- > > (Updated July 2, 2012, 6 p.m.) > > > Review request for shindig. > > > Description > ------- > > We need to decode the url before we try to parse it. My initial approach to > this was to change the way in which we build the Uri object, decoding all of > the pieces at build time. This approach caused several issues in the proxy > uri area. In order to cause less churn and risk of regression in the code, I > decided to simply decode the path in the DefaultJsUriManager > > > This addresses bug SHINDIG-1809. > https://issues.apache.org/jira/browse/SHINDIG-1809 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java > 1355827 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultJsUriManagerTest.java > 1355827 > > Diff: https://reviews.apache.org/r/5688/diff/ > > > Testing > ------- > > Added a new JUnit to address the issue of an encoded path in a Js Uri. All > existing tests pass as well. > > > Thanks, > > Stanton Sievers > >
