-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5693/
-----------------------------------------------------------
(Updated July 3, 2012, 2:17 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Description
-------
Unserializable cache keys?
Right now the Shindig Caches the 'messageBundles' and 'gadgetSpecs' with Uri
object as key, but for some cache implementation, for example, DynaCache, it
requires the key to be serializable, which Uri is not.
There are two solution for this, one, make Uri serializable 2. using a 'string'
for the key, uri.toString is good enough.
Propose to use "string" because Uri is a complex object that includes a Uri
parsers so you would need to be very careful to get it right. It would be
trivial to use a string key instead.
This addresses bug SHINDIG-1814.
https://issues.apache.org/jira/browse/SHINDIG-1814
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractSpecFactory.java
1345812
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactory.java
1345812
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultMessageBundleFactory.java
1345812
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactoryTest.java
1345812
Diff: https://reviews.apache.org/r/5693/diff/
Testing
-------
Thanks,
Erik Bi
