-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6198/
-----------------------------------------------------------
(Updated Aug. 1, 2012, 2:54 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers.
Changes
-------
Fixed white space problem raised by Ryan.
Description
-------
The gadgets/ifr endpoint will fetch the gadget xml first and then do the white
list check. It is consuming resources to fetch content when the gadget is not
allowed to render according to the gadget admin.
The proposed fix is to move the white list check ahead of processing the gadget
xml. If the gadget is not allowed to show, an error message will be returned
before doing the content fetching.
This addresses bug shindig-1830.
https://issues.apache.org/jira/browse/shindig-1830
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/process/Processor.java
1363665
Diff: https://reviews.apache.org/r/6198/diff/
Testing (updated)
-------
Done.
Thanks,
Marshall Shi
