Ryan, I just did latest pull from trunk and did mvn clean install but didnt see the test fail
How do you repro the test fail in trunk? - Henry On Thu, Aug 2, 2012 at 7:08 PM, Ryan Baxter <[email protected]> wrote: > > >> On July 31, 2012, 10:42 a.m., Ryan Baxter wrote: >> > Ship It! >> >> Erik Bi wrote: >> Ryan, could you help to commit the patch into Shindig? Thank you. > > I applied the patch to trunk and I am seeing the following tests fail when I > do a build, can you take a look at these? > > > testGetActivityEntryJsonByIds(org.apache.shindig.social.dataservice.integration.RestfulJsonActivityEntryTest) > > testGetActivityEntryJsonByGroup(org.apache.shindig.social.dataservice.integration.RestfulJsonActivityEntryTest) > > testDeleteActivityEntryJson(org.apache.shindig.social.dataservice.integration.RestfulJsonActivityEntryTest) > > > - Ryan > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5134/#review9633 > ----------------------------------------------------------- > > > On Aug. 1, 2012, 2:48 a.m., Erik Bi wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/5134/ >> ----------------------------------------------------------- >> >> (Updated Aug. 1, 2012, 2:48 a.m.) >> >> >> Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. >> >> >> Description >> ------- >> >> There are requirements to expose some specific attributes in the feed >> result. These attributes are not specific to any entry i.e. global in >> scope. for example, it is possible that user may require additional >> attributes to be passed like "Configuration parameters used by the front end >> to present Activity entries" >> Would like the RestfulCollection object to be backed by a map with the put >> and get methods exposed, similar to how ActivityEntry and ActivityObject are >> currently handled. >> >> The code in Shindig trunk does not pass extra items at the Stream level, >> only down at the Activity level. This JIRA seeks to migrate this patch back >> to Shindig such that other feed producers/renders can leverage it as well. >> >> Example: >> { >> // Want to put custom attributes here and have them returned, >> isAdmin: true, >> .... >> >> "items" : [ >> { >> "published": "2011-02-10T15:04:55Z", >> "foo": "some extension property", >> "generator": { >> "url": "http://example.org/activities-app"; >> }, >> "provider": { >> "url": "http://example.org/activity-stream"; >> }, >> "title": "Martin posted a new video to his album.", >> "actor": { >> "url": "http://example.org/martin";, >> "objectType": "person", >> "id": "tag:example.org,2011:martin", >> "foo2": "some other extension property", >> "image": { >> "url": "http://example.org/martin/image";, >> "width": 250, >> "height": 250 >> }, >> "displayName": "Martin Smith" >> }, >> "verb": "post", >> "object" : { >> "url": "http://example.org/album/my_fluffy_cat.jpg";, >> "objectType": "photo", >> "id": "tag:example.org,2011:my_fluffy_cat", >> "image": { >> "url": "http://example.org/album/my_fluffy_cat_thumb.jpg";, >> "width": 250, >> "height": 250 >> } >> }, >> "target": { >> "url": "http://example.org/album/";, >> "objectType": "photo-album", >> "id": "tag:example.org,2011:abc123", >> "displayName": "Martin's Photo Album", >> "image": { >> "url": "http://example.org/album/thumbnail.jpg";, >> "width": 250, >> "height": 250 >> } >> } >> } >> ] >> } >> >> >> This addresses bug shindig-1779. >> https://issues.apache.org/jira/browse/shindig-1779 >> >> >> Diffs >> ----- >> >> >> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/common/JsonSerializer.java >> 1327432 >> >> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/RestfulCollection.java >> 1339011 >> >> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanXStreamConverter.java >> 1327432 >> >> http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/protocol/RestfulCollectionTest.java >> 1361065 >> >> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomFeed.java >> 1339014 >> >> Diff: https://reviews.apache.org/r/5134/diff/ >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Erik Bi >> >> >
![http://example.org/album/my_fluffy_cat.jpg"](http://example.org/album/my_fluffy_cat.jpg"){kind=link}
![http://example.org/album/my_fluffy_cat_thumb.jpg"](http://example.org/album/my_fluffy_cat_thumb.jpg"){kind=link}
![http://example.org/album/thumbnail.jpg"](http://example.org/album/thumbnail.jpg"){kind=link}