----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5973/#review10270 -----------------------------------------------------------
Ship it! Committed r1372882 Please close the review. - Dan Dumont On Aug. 8, 2012, 2:08 a.m., Erik Bi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5973/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 2:08 a.m.) > > > Review request for shindig, Ryan Baxter, Dan Dumont, and Stanton Sievers. > > > Description > ------- > > According to the spec, you can define a in-line variable via <os:Var> > > http://opensocial-resources.googlecode.com/svn/spec/2.0.1/OpenSocial-Templating.xml#rfc.section.8.2 > > Seems this feature is not implemented in Shindig Java version right now (seen > from the code, it's implemented in PHP version. > > This patch is to add os:Var support for shindig template > > > This addresses bug shindig-1737. > https://issues.apache.org/jira/browse/shindig-1737 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/templates/VarTag.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateModule.java > 1366998 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/VarTagHandler.java > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/tags/VarTagHandlerTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5973/diff/ > > > Testing > ------- > > > Thanks, > > Erik Bi > >
