> On Aug. 14, 2012, 2:02 p.m., Ryan Baxter wrote: > > LGTM. Could we add some unit tests for this? I know the JSUnit tests can > > sometime be pointless but it seems like we already have tests that call > > addAction in the container and then checks to see if the action is in the > > registry. It looks like some of the more meaningful tests are commented > > out.... > > Henry Saputra wrote: > > Hmm which tests were you referring to?
The tests here http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6606/#review10271 ----------------------------------------------------------- On Aug. 14, 2012, 1:46 p.m., Dan Dumont wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6606/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2012, 1:46 p.m.) > > > Review request for shindig and Henry Saputra. > > > Description > ------- > > Container should not call showAction API for actions with an invalid type. > > > This addresses bug SHINDIG-1854. > https://issues.apache.org/jira/browse/SHINDIG-1854 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1372400 > > Diff: https://reviews.apache.org/r/6606/diff/ > > > Testing > ------- > > > Thanks, > > Dan Dumont > >
