----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6436/#review10425 -----------------------------------------------------------
+1 to Ryan, I would like to see more code comments and javadoc http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java <https://reviews.apache.org/r/6436/#comment22218> Could you please overload this method so that you don't need to specify junk params? http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java <https://reviews.apache.org/r/6436/#comment22210> I don't generally like to do a lot of things inside synchronized blocks. Can the logging below here be moved out of the block? Can we log with a level? Is haveRefreshToken(acc) the only contentious call here? We call it 3 tiems, can we call it once and then exit the sync block? http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java <https://reviews.apache.org/r/6436/#comment22219> Can we log with a level? http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java <https://reviews.apache.org/r/6436/#comment22220> Can you use Joiner.on(':') here? http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java <https://reviews.apache.org/r/6436/#comment22221> Can you put a line here documenting what this is doing? I'm not sure what a persister is and why it's different than a cache, or why we need to clean up both and one doesn't do the other. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandler.java <https://reviews.apache.org/r/6436/#comment22222> Can you overload this constructor so you don't have to pass junk params? http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java <https://reviews.apache.org/r/6436/#comment22223> Please use Joiner.on(':') http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java <https://reviews.apache.org/r/6436/#comment22224> Can you please collapse this code and use a ternary operator to pass in your message if accessor.isValid() or not? - Dan Dumont On Aug. 13, 2012, 12:33 p.m., Adam Clarke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6436/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2012, 12:33 p.m.) > > > Review request for shindig, Stanton Sievers, Brian Lillie, and Marshall Shi. > > > Description > ------- > > Latest (and probably last) iteration of OAuth2 Consumer fixes rolled up into > a single patch. > > Applied formatting and Checkstyle fixes to all changed files. > MapCache inconsistent null checks for storing Collections. > update OAuth2Persister javadoc to clarify what findClient() should return. > BasicOAuth2Store improve removeToken() logic, from Brian Lillie. > Refreshing Token does not include originator info. > Improve information propagated through OAuth2RequestException. > More complete filtering of server information when sendTraceToClient is > disabled. > Log when an invalid or error OAuth2Accessor is used for redirect. > Limit concurrent refreshes to 1, syncrhonizing on interned accessor string. > Refresh token is not properly removed on provider error. > Allow clearing of accessor cache on OAuth2Store. > > > This addresses bug SHINDIG-1839. > https://issues.apache.org/jira/browse/SHINDIG-1839 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Request.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/BasicOAuth2Store.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Module.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestException.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/OAuth2Store.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandler.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/BearerTokenHandler.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientAuthenticationHandler.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/ClientCredentialsGrantTypeHandler.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/CodeAuthorizationResponseHandler.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/MacTokenHandler.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerError.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/StandardAuthenticationHandler.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/handler/TokenAuthorizationResponseHandler.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/MapCache.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth2/persistence/OAuth2Persister.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/OAuth2CallbackServlet.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/BasicAuthenticationHandlerTest.java > 1372387 > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java > 1372387 > > Diff: https://reviews.apache.org/r/6436/diff/ > > > Testing > ------- > > All existing JUnits pass > > > Thanks, > > Adam Clarke > >
